Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual regression test for loading skeleton with prefers-reduced-motion true #5002

Open
zackkrida opened this issue Sep 28, 2024 · 0 comments
Open

Add visual regression test for loading skeleton with prefers-reduced-motion true #5002

zackkrida opened this issue Sep 28, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

Problem

We don't have any VR tests capturing the appearance of our loading state because it "shimmers" and thus can't be reliably snapshotted.

We can however capture the appearance for users with reduced motion enabled.

Description

Add VR tests for the image, audio, and "all" results grids to capture the loading state. This probably involves blocking or delaying the API requests.

Alternatives

Additional context
@zackkrida zackkrida added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Sep 28, 2024
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zackkrida @dhruvkb