Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom out returns after inserter is closed #66328

Open
3 of 6 tasks
draganescu opened this issue Oct 22, 2024 · 4 comments
Open
3 of 6 tasks

Zoom out returns after inserter is closed #66328

draganescu opened this issue Oct 22, 2024 · 4 comments
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Description

Disabling zoom out while the inserter is open makes it come back when the inserter is closed.

Step-by-step reproduction instructions

the-return-of-the-zoom-out.mp4

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@draganescu draganescu added [Feature] Zoom Out [Type] Bug An existing feature does not function as intended labels Oct 22, 2024
@draganescu
Copy link
Contributor Author

This is because of the useZoomOut hook "toggling" the state instead of setting it.

@draganescu draganescu added the [Priority] High Used to indicate top priority items that need quick attention label Oct 22, 2024
@Mamaduka
Copy link
Member

I also noticed that the useZoomOut hook is public and shipped with WP 6.6. It should've been a private hook.

@jeryj
Copy link
Contributor

jeryj commented Oct 22, 2024

I also noticed that the useZoomOut hook is public and shipped with WP 6.6. It should've been a private hook.

Yup -- that is true.

@draganescu - @ajlende and I are testing this and unable to reproduce on the 6.7 branch. Can you try again on 6.7?

@jeryj jeryj removed the [Priority] High Used to indicate top priority items that need quick attention label Oct 22, 2024
@jeryj
Copy link
Contributor

jeryj commented Oct 22, 2024

Confirmed this a bug on trunk, not on wp/6.7. I remove it from the wp/6.7 board and removed the high priority tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants