Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient color contrast for the post list title badge and the post card title badge #66322

Open
3 of 6 tasks
afercia opened this issue Oct 22, 2024 · 0 comments
Open
3 of 6 tasks
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Oct 22, 2024

Description

Some special Pages (and potentially other objects edited in the editor) show a 'badge' with an additional label to clarify the special nature fo the edited object. For example: The page set as home page and the page set as posts page.

These badges belong to different components but they use the same design pattern. The color contrast is insufficient gor both:
Text color: #757575
Background color: #f0f0f0

That gives a color contrast of only 4.04:1. It should be at least 4.6:1

To help search through the c odebase, the CSS selectors for these are:
edit-site-post-list__title-badge
editor-post-card-panel__title-badge

Cc @WordPress/gutenberg-design

Step-by-step reproduction instructions

  • Go to the wp-admin Reading Settings.
  • Set your homepage to display a static page.
  • Set a Posts page.
  • Go to the Site editor > Pages.
  • In the list of pages, search for the pages used for the homepage and posts page.
  • Observe they both show a 'badge' with an additional label.
  • Observe the color contrast of the badge is insufficient.
  • Select one of these special pages.
  • In the Settings panel, observe the color contrast of the badge in the post card panel is insufficient.

Screenshots, screen recording, code snippet

Image

Image

Image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant