You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The GH Actions test and quicktest workflows currently contain a "Access localhost on port 9002" step, which is not working correctly.
- name: Access localhost on port 9002run: curl -i http://localhost:9002
Results in:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
HTTP/1.1 502 Bad Gateway
Server: mitmproxy 10.4.2
Connection: close
Content-Type: text/html
content-length: 231
<html><head><title>502 Bad Gateway</title></head>
100 231 100 231 0 0 43008 0 --:--:-- --:--:-- --:--:-- 46200
<body><h1>502 Bad Gateway</h1><p>Connection killed: Request destination unknown. Unable to figure out where this request should be forwarded to.</p></body></html>
We should add the Curl -f flag to fail the step when the connection was not correctly made.
However, as things are, adding the -f flag would currently fail the step, so we first need to do something to improve the step and get it passing properly.
Additionally, we should add a second step to run a similar access test on port 9003.
Lastly, as - even with this failing proxy check - the tests are passing, we should verify that there are sufficient tests for the proxy handling in Requests.
The text was updated successfully, but these errors were encountered:
The GH Actions
testandquicktestworkflows currently contain a "Access localhost on port 9002" step, which is not working correctly.Results in:
% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 HTTP/1.1 502 Bad Gateway Server: mitmproxy 10.4.2 Connection: close Content-Type: text/html content-length: 231 <html> <head> <title>502 Bad Gateway</title> </head> 100 231 100 231 0 0 43008 0 --:--:-- --:--:-- --:--:-- 46200 <body> <h1>502 Bad Gateway</h1> <p>Connection killed: Request destination unknown. Unable to figure out where this request should be forwarded to.</p> </body> </html>We should add the Curl
-fflag to fail the step when the connection was not correctly made.However, as things are, adding the
-fflag would currently fail the step, so we first need to do something to improve the step and get it passing properly.Additionally, we should add a second step to run a similar access test on port 9003.
Lastly, as - even with this failing proxy check - the tests are passing, we should verify that there are sufficient tests for the proxy handling in Requests.
The text was updated successfully, but these errors were encountered: