Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API is case sensitive #49

Open
rmvermeulen opened this issue Jun 29, 2016 · 4 comments
Open

API is case sensitive #49

rmvermeulen opened this issue Jun 29, 2016 · 4 comments

Comments

@rmvermeulen
Copy link
Contributor

This is counter to common practice.
api/rest/mediaProfiles/ and api/rest/mediaprofiles/
Should be aliases of each other, not separate endpoints.

We accidentally ran into this today. I couldn't figure out how fix this at a glance, so I didn't. The discussion here at least confirms it should be insensitive, but it's not really a big deal.

@ronkorving
Copy link

IMHO it should be case sensitive. But iirc Express defaults to case insensitivity. I guess we should follow Express settings?

@rmvermeulen
Copy link
Contributor Author

Since it uses express' router, I think using those settings would be the expected behaviour. We ourselves always use lowercase paths anyway so should not hit this outside of testing.

@ronkorving
Copy link

Wanna PR this? :)

@rmvermeulen
Copy link
Contributor Author

Halfway there :) Can't allocate too much time currently

pfyvie added a commit to pfyvie/express-rested that referenced this issue Oct 26, 2016
pfyvie added a commit to pfyvie/express-rested that referenced this issue Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants