Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor people and works functions #420

Open
marfox opened this issue Aug 19, 2021 · 0 comments
Open

Refactor people and works functions #420

marfox opened this issue Aug 19, 2021 · 0 comments
Labels
story Task with multiple sub-tasks
Milestone
Refactoring & doc...

Comments

@marfox
Copy link
Member

marfox commented Aug 19, 2021

there seems to be significant duplication among people_cli/works_cli and add_works_statements/add_people_statements, as well as other functions here (_add_or_reference/_add_or_reference_works) is it worth it to abstract a little to make future changes easier?

Originally posted by @e-dorigatti in #419 (comment)
@marfox marfox added the story Task with multiple sub-tasks label Aug 19, 2021
@marfox marfox added this to the Refactoring & documentation milestone Aug 19, 2021
This was referenced Aug 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
story Task with multiple sub-tasks
Projects
None yet
Milestone
Refactoring & documentation
Development

No branches or pull requests
1 participant
@marfox