Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frametick woes #5567

Open
emptyrivers opened this issue Dec 3, 2024 · 0 comments
Open

frametick woes #5567

emptyrivers opened this issue Dec 3, 2024 · 0 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. 🏃 Performance Issue This issue concerns the performance impact of WeakAuras.

Comments

@emptyrivers
Copy link
Contributor

emptyrivers commented Dec 3, 2024

If you have a decently populated aura list & you run a profile while "idle", you are likely to get a large "frame tick" system result, relative to the apparent activity of WeakAuras. This is because it's fairly common for auras to include a subtext with %p (more convenient than a cooldown number if you like to tweak visuals without installing other addons), which registers the subregion for frame tick whenever the subregion is shown. Unfortunately, this causes WeakAuras to re-create the text string every frame, even when it "should" know better, to the tune of (for a typical set of loaded auras) 100+ basis points of (admittedly extremely even) "time in WA".

Since we have the capacity to unsubscribe a subregion from FrameTick whenever, it would be nice if we did so for subtexts with just %p pattern which would result in either displaying static progress, or empty string - both of these require a trigger update or progress source change before they would display a new string.

@emptyrivers emptyrivers added 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. 🏃 Performance Issue This issue concerns the performance impact of WeakAuras. labels Dec 3, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Dec 3, 2024
@WeakAuras WeakAuras deleted a comment from ScoFoZo Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. 🏃 Performance Issue This issue concerns the performance impact of WeakAuras.
Projects
None yet
Development

No branches or pull requests

1 participant