Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firi piece set #867

Open
Mansindam opened this issue Sep 23, 2024 · 6 comments
Open

Firi piece set #867

Mansindam opened this issue Sep 23, 2024 · 6 comments

Comments

@Mansindam
Copy link

Mansindam commented Sep 23, 2024

image

Would lishogi be interested in providing this set with strong visual clarity?

@WandererXII
Copy link
Owner

Looks really nice I would be happy to add it!

@jfaure
Copy link

jfaure commented Sep 28, 2024

I can't easily tell what's going on in the piece dir, although it looks like we can maybe get away with raw inline css?
In which case I'm using this which is well tested: https://userstyles.world/style/18241/firi-pieceset-lishogi

@WandererXII
Copy link
Owner

If you send me the pieces I can add them to the piece dir myself, it's better to have all the pieces in one place, in case something changes in the future I can easily regenerate the css sheets.

@jfaure
Copy link

jfaure commented Oct 1, 2024

https://github.com/jfaure/Firi-pieceset

You can reproduce my script or probably simpler to copy them from the out/ directory, those are simplified from the templates to clear out mirror path effects and add opposite color.

Hopefully it is finished, even though I seem to keep finding small adjustments

@jfaure
Copy link

jfaure commented Oct 7, 2024

I've drawn more pieces for cannon shogi, chu, tori etc.. I'm now exploiting multi-page batch exports to leverage clones, among other things.

It's making less and less sense to try mirror the sources here, which are rather dependent on inkscape and aren't exclusive to lishogi - I strongly recommend to simply inline the css and link to the external source.

@jfaure
Copy link

jfaure commented Oct 15, 2024

image

This is the state of affairs at the moment, I've lost enthusiasm for drawing things for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants