Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Post Prominence Doesn't Work #1862

Open
ghost opened this issue Jun 3, 2020 · 7 comments
Open

Deleting Post Prominence Doesn't Work #1862

ghost opened this issue Jun 3, 2020 · 7 comments

Comments

@ghost
Copy link

ghost commented Jun 3, 2020

Title says most of it. When I try to delete some of the default post prominences that I am not using, they just come back! A fix would be cool, but moreover is someone could point me in the right direction of where I could:

  1. Deregister the post prominences in my child theme (ideal)
  2. Delete them where they are registered within largo (less ideal, but willing to do this)

Beyond that, if anyone has thoughts on where the bug is originating, I would be happy to take a crack at fixing it and submitting a PR.

@benlk
Copy link
Collaborator

benlk commented Jun 3, 2020

Hi! To help us figure out how best to resolve this request, we have some questions:

  • which version of Largo are you on?
  • which prominence terms are you deleting?

@benlk
Copy link
Collaborator

benlk commented Jun 3, 2020

(possibly related: #1799)

@ghost
Copy link
Author

ghost commented Jun 3, 2020

I am on version 0.6.4 and am using a child theme. I'm trying to delete homepage featured and homepage top story.

Thanks for the help! I'll peep issue 1799 to see if that has anything that might help me too.

@benlk
Copy link
Collaborator

benlk commented Jun 3, 2020

Are you using a custom homepage layout, or one of the ones in https://github.com/INN/largo/tree/v0.6.4/homepages/layouts ?

@ghost
Copy link
Author

ghost commented Jun 10, 2020

I am using the "Top Stories" layout

@benlk
Copy link
Collaborator

benlk commented Jun 10, 2020

The "Homepage Featured" and "Homepage Top Story" prominence terms are being automatically registered by your homepage layout because they drive how that homepage layout works. https://github.com/INN/largo/blob/v0.6.4/homepages/layouts/TopStories.php#L17-L28

Those prominence terms affect how posts are displayed on the homepage; the specifics are explained at https://largo.inn.org/guides/administrators/theme-options/layout/homepage-layout-top-stories/

If you don't mind my curiosity: Why don't you use those prominence terms?

@ghost
Copy link
Author

ghost commented Jun 10, 2020

Good deal! That information is exactly what I needed. I will probably just shift away from those and work at moving towards a custom homepage.

As far as why I don't use them, it's a naming thing. I did a big no-no when I couldn't get custom my custom homepage to work and just made some small tweaks to TopStories in the parent theme. Basically all I did was remove the three featured stores from the box that contains the top story and the top story is taking up the full width of that box. I want to remove that option because the top story happens to be labeled "This Week's Feature" on the front in (per client request) and the existence of that other option is causing confusion.

Anyhow, this was very helpful and I will consider my self created issue resolved. Thanks so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant