You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if the variable is set to false, then because ! empty( false ) === false, the fallback option of true is used.
This can be fixed by switching to isset( ... ) ? ... : ... ;, and making sure that where we use partials/widget-content.php, like in the Largo Recent Posts widget, we do so passing false explicitly.
The default behavior of the widget is to only save the positive, checked value, to assertively hide the date, so rather than testing for the absence of the negative value, should we not instead test for the presence of the positive value?
benlk
added a commit
to INN/umbrella-mstoday
that referenced
this issue
Mar 25, 2020
https://github.com/INN/largo/blob/13e1777b1f39484698d5744a8f0f432be1ee098c/partials/widget-content.php#L45
if the variable is set to
false
, then because! empty( false ) === false
, the fallback option oftrue
is used.This can be fixed by switching to
isset( ... ) ? ... : ... ;
, and making sure that where we usepartials/widget-content.php
, like in the Largo Recent Posts widget, we do so passingfalse
explicitly.This is the bug in INN/umbrella-voiceofoc#36.
The text was updated successfully, but these errors were encountered: