error callback / complete callback are not actually used in inspect

[Jamesernator]

The inspect method defines error callback and complete callback, however it never actually calls them inside error/complete observer methods.

The steps should probably be similar to the steps for the next callback (i.e. passing thrown errors to subscriber.subscribe).

[Jamesernator]

One consideration, perhaps for error we should be using SuppressedError from the (currently being implemented) explicit resource management proposal for the error case.

i.e. The steps would be equivalent to:

error: (error) => {
    try {
        errorCallback?.(error);
        subscriber.error(error);
    } catch (inspectError: unknown) {
        subscriber.error(
            new SuppressedError(
                inspectError,
                error,
                `inspector error callback threw an error`,
            ),
        );
    }
},

[domfarolino]

Thanks for catching this. I'll fix the immediate bug to bring it inline with the implementation (#176), and link to #150 to consider the explicit resource management proposal as a follow-up.

[domenic]

I think it might be worth a separate issue to discuss the SupressedError idea in particular, as it's a change in semantics, apart from the addition of Symbol.dispose.

[domfarolino]

Done (#177) thanks!