Add column settings editor #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tambeta
requested changes
Jun 15, 2020
|
|
||
| var settingsBtn = document.querySelector('.js-settings-btn'); | ||
|
|
||
| var SettingsEditor = new Edicy.SettingsEditor(settingsBtn, { |
There was a problem hiding this comment.
Siin peaks eelnema kontroll, kas settingsBtn on väärtustatud.
| var SettingsEditor = new Edicy.SettingsEditor(settingsBtn, { | ||
| menuItems: [ | ||
| { | ||
| "title": "Columns count", |
There was a problem hiding this comment.
Siin peaks nähtavasti ka tõlked olema, aga see teada.
| }); | ||
| } | ||
| }); | ||
| document.querySelector('.js-settings-btn').removeAttribute('disabled'); |
There was a problem hiding this comment.
Piisab
settingsBtn.removeAttribute('disabled');|
|
||
| {% assign column_settings = page.data.column_settings %} | ||
|
|
||
| {% if column_settings.items_count != nil and column_settings.items_count != "" %} |
There was a problem hiding this comment.
Kas Liquidis mingit blank?-stiilis kontrolli (a la Ruby) ei ole, või peabki alati nil ja "" vastu kontrollima?
Comment on lines
+29
to
+30
| {% if column_settings.padding %} | ||
| {% endif %} |
Comment on lines
+70
to
+72
| {% if editmode %} | ||
| <button disabled class="js-settings-btn">columns editor</button> | ||
| {% endif %} |
There was a problem hiding this comment.
See võiks ka sisse trepitud olla ühtsuse ja ilusa koodi mõttes. Allpool samamoodi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lisatud:
Modulaarsed sisualad, millega on võimalik lisada üksteise korvale sisualasid, määrata padding ja maksimaalne laius.
Testimine:
Kuna lisatud on olemasolevale sisualale, siis kontrollida lisaks funktsionaalsusele ka seda, et olemasolev sisu ei muutuks.
Close #322