Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header menu color should depend on topbar bg color if it is defined. #252

Open
kaspar-naaber opened this issue May 25, 2017 · 0 comments
Open

Header menu color should depend on topbar bg color if it is defined. #252

kaspar-naaber opened this issue May 25, 2017 · 0 comments
Labels
bug important

Comments

@kaspar-naaber
Copy link
Contributor

If topbar doesn't have a bg color, the main menu color theme is decided using the header's bg-picker calculated lightness. If topbar bg-color is set from the Design Editor it adds additional color layer and using bg-picker's lightness doesn't make sense anymore. For example there might be a situation where menu is white and topbar has white bg:

may-25-2017 14-33-52
@kaspar-naaber kaspar-naaber self-assigned this May 25, 2017
@kaspar-naaber kaspar-naaber removed their assignment Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaspar-naaber