Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish background wavy lines #17

Open
hanson-lam opened this issue Mar 31, 2023 · 2 comments
Open

Polish background wavy lines #17

hanson-lam opened this issue Mar 31, 2023 · 2 comments
Assignees
@IanMacDougall @CarolineRinks @hanson-lam @dhuang0212
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@hanson-lam
Copy link

** !! THIS ISSUE IS NOT A PRIORITY. JUST ADDING DOCUMENTATION HERE FOR THE PROBLEM !!**

The wavy lines in the background don't extend the full screen. Additionally, when viewing the webpage in dark mode, the lines look very grainy. See the attached photos for a comparison.

Our webpage:
Screenshot 2023-03-31 at 3 04 15 AM

Official webpage:
Screenshot 2023-03-31 at 3 04 28 AM
@hanson-lam hanson-lam added this to the Class Demo milestone Mar 31, 2023
@CarolineRinks CarolineRinks added the enhancement New feature or request label Mar 31, 2023
@IanMacDougall
Copy link
Collaborator

If you can find a quick solution, good; otherwise remove the image and we can add it later for final

@CarolineRinks
Copy link

The original Ocean Market's background waves image is 2050x352 pixels. Our background pic is 1920x1080 pixels because that is the resolution of my laptop. The waves are generated by running the code on CodePen and then taking a screenshot of the generated image, so I'm not sure how to increase the resolution to the 2050x352. Any ideas?

@IanMacDougall IanMacDougall modified the milestones: Class Demo, Final Demo Apr 11, 2023
@IanMacDougall IanMacDougall modified the milestones: Final Demo, Backlog May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanMacDougall IanMacDougall

@CarolineRinks CarolineRinks

@hanson-lam hanson-lam

@dhuang0212 dhuang0212

Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

17-polish-background-wavy-lines VizerISD/personalhealthcarewallet
4 participants
@IanMacDougall @CarolineRinks @hanson-lam @dhuang0212