Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloop's JVM version too low will not fail the compilation #3116

Open
MaciejG604 opened this issue Aug 19, 2024 · 0 comments
Open

Bloop's JVM version too low will not fail the compilation #3116

MaciejG604 opened this issue Aug 19, 2024 · 0 comments
Labels
Bloop Issues tied with Bloop integration. bug Something isn't working good first issue Good for newcomers jvm Issues tied to the JVM platform

Comments

@MaciejG604
Copy link
Contributor

After merging #3112, Bloop will no longer fail when compiling with required jvm version higher than the version it's running on. The outline of the problem is:

The test with correct bloop JVM version is a weird case since in old behaviour we never send java-19 path to bloop before the workspace reload. So we were sending java-11 and the --release 19 resulted in an error during compilation. New behaviour is we send java-19 path and the compilation succeeds, but we get some error logs from bloop from whetever it's doing with the compiler jar 🤷.

This won't affect Metals users as I think, we get a workspace reload everytime project configuration changes. However for IJ user this might be confusing.

Potential workaround:

  • On every 'prepareBuild()' check if bloop's jvm version is too low and restart Bloop - this will requires either ugly code or a bigger refactor
  • On every 'prepareBuild()' check if bloop's jvm version is too low and fail the build process with a readable diagnostic for the user - this should be much easier
@MaciejG604 MaciejG604 added bug Something isn't working Bloop Issues tied with Bloop integration. jvm Issues tied to the JVM platform good first issue Good for newcomers labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bloop Issues tied with Bloop integration. bug Something isn't working good first issue Good for newcomers jvm Issues tied to the JVM platform
Projects
None yet
Development

No branches or pull requests

1 participant