Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding VictoriaMetrics Operator CRD and Prometheus Operator CRD #1119

Open
Hazmi35 opened this issue Sep 30, 2024 · 2 comments
Open

Comments

@Hazmi35
Copy link

Hazmi35 commented Sep 30, 2024

The docs specified that:
So you can use familiar CRD objects: ServiceMonitor, PodMonitor, PrometheusRule, Probe and AlertmanagerConfig..

And there is also an auto-conversion of Prom Operator CRD to VM Operator CRD, it also syncs but the docs also specified that:
It DOES NOT delete converted objects after original ones are deleted.

My use-case here is to use VM Operator CRDs for my own apps/metrics, but use Prometheus Operator CRDs for Helm Charts that I cannot modify myself without forking (one such case is CloudNative-PG, it uses PodMonitor). Although the auto-conversion really helps here but the fact that the converted object will not be deleted after the original ones is deleted is kinda no no for me.

My question is,

  1. Does this operator supports reading ServiceMonitor/PodMonitor without auto-conversion but still treats them the same way as VMServiceScrape/VMPodScrape? (In my setup, I tried. It doesn't scrape any ServiceMonitor/PodMonitor)
  2. Would a support for an auto-deleted converted objects from auto-conversion be possible?
@sdomme
Copy link

sdomme commented Nov 8, 2024

The question might not be relevant anymore, but regarding the deletion of converted object this setting does actually exactly this.

@Hazmi35
Copy link
Author

Hazmi35 commented Nov 8, 2024

The question might not be relevant anymore, but regarding the deletion of converted object this setting does actually exactly this.

Oh! Didn't catch that. Is that new? Well perhaps it's because I used the victoria-metrics-k8s-stack chart which omits that option from the default values file.

The docs are still saying It DOES NOT delete converted objects after original ones are deleted. though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants