Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archetypes incorrectly rely on J2CL name mangling #196

Closed
niloc132 opened this issue Oct 12, 2022 · 1 comment · Fixed by #198
Closed

Archetypes incorrectly rely on J2CL name mangling #196

niloc132 opened this issue Oct 12, 2022 · 1 comment · Fixed by #198
Labels
j2cl Related to the j2cl transpiler
Milestone

Comments

@niloc132
Copy link
Member

niloc132 commented Oct 12, 2022

The next Vertispan tag of J2CL will have a chance in how name mangling works, which breaks our current archetypes and some unit tests. Instead, example code should always use jsinterop before trying to reference Java symbols from JS.

Unfortunately, with the default flags, this is identified as a compile time warning rather than an error, and won't cause an error until runtime.

Consider backporting this and releasing a 0.20.1 if 0.21 takes too long, to avoid the number of broken apps build by archetypes.

@niloc132 niloc132 added the j2cl Related to the j2cl transpiler label Oct 12, 2022
@niloc132 niloc132 added this to the 0.21 milestone Oct 12, 2022
@niloc132
Copy link
Member Author

See also #197, which could help users to catch this class of issue (and others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
j2cl Related to the j2cl transpiler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant