Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bring back X11DRV_GET_DRAWABLE (winex11.drv, needed by nine) #161

Open
axeldavy opened this issue Oct 15, 2022 · 2 comments
Open

Comments

@axeldavy
Copy link

Hey there.

Despite what the original commit removing the function said, it's not unused:

96b8220

Indeed it's used by ... gallium nine.

Having gallium nine work with proton has been something requested many times by users:
iXit/wine-nine-standalone#131

Since wine devs didn't want nine do be part of the wine package, nine cannot access wine internal structures. Since we don't present through gl or vk, nine needs to get the X drawable somehow. And that's exactly what this function enables nine to do.
I don't see any other way nine could work without this function (or a remplacement one, but let's keep the code similar with the main wine tree, right ?)
I don't think adding back the function hurts anything, so...

@okias
Copy link
Contributor

okias commented Jan 25, 2023

Bump, the issue is still valid. Please revert if possible!

@GloriousEggroll
Copy link
Contributor

looks like this was done finally

GloriousEggroll pushed a commit to GloriousEggroll/proton-wine that referenced this issue Jan 30, 2023
This reverts commit 6a395d94eeba987b69a16eb0dd29b80f271780e9.

Link: ValveSoftware#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants