feat(Gallery): add prop arrowClickableArea to arrows
#7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7907 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 378 379 +1
Lines 11196 11205 +9
Branches 3735 3735
=======================================
+ Hits 10670 10679 +9
Misses 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit ad8b51e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Необходимо реализовать возможность изменения кликабельной зоны стрелок переключения слайдов для компонента Gallery
Изменения
Изначально хотел доработать компонент
ScrollArrowи добавить в него свойствоarrowClickableArea, чтобы можно было переиспользовать в других компонентах, не только вGallery. Но понял, что без серьезных изменений в верстке компонента данное изменение сделать не получится, так как вScrollArrowкорневой компонент -buttonи все свойства завязаны наbutton. А для реализацииarrowClickableAreaпришлось бы сделать корневой компонентdiv. В общем пришлось отказаться от этой идеи и добавить свойствоarrowClickableAreaтолько дляGallery. По итогуarrowClickableAreaс двумя значениями'fill'и'fit'ScrollArrows, который рендерит обе стрелки и переиспользовалCarouselBaseиBaseGalleryRelease notes
Улучшения
arrowClickableAreaдля изменения кликабельной области стрелок