-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: new-episode notification appeared and/or not removed after I've marked an episode as watched #776
Comments
Thanks, I'll look into this later. Currently busy with TMDB migration. As I just recently saw the code I don't think there is a bug: before a notification runs it queries for the episodes to show, explicitly including only not watched ones. |
@UweTrottmann Perhaps I chose "watched" while it showed the notification, and the notification stayed? |
@UweTrottmann I've tested now. If you get a notification, and instead of doing anything with it, you go to the app and mark it as watched, the notification doesn't go away. |
Couldn't see the original issue, but this one does exist. |
Thanks, this is currently by design. It would require some additional book-keeping of what notification is currently shown. To then clear it when one of the episodes is marked watched. Maybe if I have some time in the future... |
@UweTrottmann Doesn't it have something extra in it, of the ID of the TV series and the episode, to go there? |
Describe the bug
I've marked an episode as watched, and later got a notification of it.
To Reproduce
Expected behavior
Notification shouldn't appear, as I've already watched the episode.
Screenshots
Sorry too late.
Smartphone (please complete the following information):
Various, but why would that matter?
"57", version code : 2105705.
Additional context
¯_(ツ)_/¯
The text was updated successfully, but these errors were encountered: