Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Version doesn't compile #117

Open
Vithanco opened this issue Feb 4, 2018 · 2 comments
Open

Mac Version doesn't compile #117

Vithanco opened this issue Feb 4, 2018 · 2 comments

Comments

@Vithanco
Copy link

Vithanco commented Feb 4, 2018

I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS.

#if os(iOS)
    public func useStoreKitReviewPrompt() -> Bool {
...

but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions.

    public var shouldTryStoreKitReviewPrompt : Bool {
        if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true }

Please review. Thanks for this great library.

@Vithanco
Copy link
Author

Vithanco commented Feb 4, 2018

I don't think this issue was introduced with a8c1dfd.

@coneybeare
Copy link
Member

coneybeare commented Feb 28, 2018

It was introduced on #112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants