Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labtool uses too much of memory on courses with lots of students #944

Open
mjaakko opened this issue Nov 18, 2019 · 1 comment
Open

Labtool uses too much of memory on courses with lots of students #944

mjaakko opened this issue Nov 18, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mjaakko
Copy link
Contributor

mjaakko commented Nov 18, 2019

This is probably caused by components receiving unnecessary data as a prop which creates a lot of copies in memory.

Related to #941

@mjaakko mjaakko changed the title Labtool uses a lot of memory on courses with lots of students Labtool uses too much of memory on courses with lots of students Nov 18, 2019
@mjaakko mjaakko added the bug Something isn't working label Nov 18, 2019
@gotonode gotonode added the sprint 6 (2019) Team Labtool 2019's 6th Sprint label Nov 18, 2019
@mjaakko
Copy link
Contributor Author

mjaakko commented Nov 27, 2019

This might be too difficult to solve properly. Currently Labtool fetches all data from one course (this could be at least few megabytes for courses with lots of students) and passes that as a prop to many React components. We could filter that data to pass only what is needed as a prop, but proper fix would be to fetch only data that is needed from the backend and this would require rewriting most of current code.

@hisahi hisahi removed the sprint 6 (2019) Team Labtool 2019's 6th Sprint label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants