Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint set up with Husky pre-commit hook #338

Open
treystevens opened this issue Feb 28, 2020 · 0 comments
Open

Lint set up with Husky pre-commit hook #338

treystevens opened this issue Feb 28, 2020 · 0 comments

Comments

@treystevens
Copy link
Member

Intended / expected behavior with "pre-commit": "npm run lint" in our package.json:

  1. Files in staging have lint errors
  2. Lint errors are fixed with a pre-commit hook
  3. Files pushed to GitHub with the lint fix

Actual behavior:

  1. Files in staging have lint errors
  2. Lint errors are fixed with a pre-commit hook
  3. Files in step 1 prior to npm run lint are committed instead of the newly modified files after running the pre-commit hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant