Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 feat can interface node #12

Closed
wants to merge 122 commits into from
Closed

5 feat can interface node #12

wants to merge 122 commits into from

Conversation

Jack17432
Copy link
Member

Description

Issue #5

ros2 Driver node for the can interface on the jetson nano

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

TBD

  • Test output topic
  • Test input servic
  • Run physical harware test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jack17432 Jack17432 self-assigned this Feb 25, 2023
@Jack17432 Jack17432 linked an issue Feb 25, 2023 that may be closed by this pull request
[✨FEAT✨]: CAN interface node #5
Open
1 task
Zane-Larking
Zane-Larking reviewed Mar 28, 2023
View reviewed changes
src/moa/moa_driver/moa_driver/can_interface_jnano.py
Comment on lines +28 to +32
self.service_can = self.create_service(
CANSendReq,
'publish_can_data',
self.callback_publish_can_data
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to topic reader, topic is /pub_raw_can, using CANStamped message, 10 is the service type, self.callback_publish_can_data

dyu056 and others added 28 commits October 28, 2023 17:18
@dyu056
Merge pull request #63 from UOA-FSAE/26-feat-cone-detection
a42ce59 
26 feat cone detection
@dyu056
Modify docker container for Daniel'S PC
fdae015
@dyu056
zed container updated to have autonomouus file, but zed_wrapper does …
8d78673 
…not work properlly
@dyu056
Fix docker for installing necessary dependencies
f40a1b1
@YachtChen
Add files via upload
87cf20d
@dyu056
add pos and rot in detector worked
9d96fad
@YachtChen
Add files via upload
93efd36
@dyu056
finalize for today, still need to do test
d7b6c31
@dyu056
Merge remote-tracking branch 'origin/cone-detect-map-test' into cone-…
aba05d3 
…detect-map-test

# Conflicts:
#	src/moa/cone-detection/cone_detection/detection_final.py
@dyu056
Make topic uniform
098b7d8
@dyu056
Make topic uniform, add one line command to run cone detection
bc80515
@YachtChen
Cleanned
61bc3c3 
Turned all global variable into class owned variables. Add camera localization
@dyu056
Add translation and rotation info
b7bd6d0
@dyu056
Merge remote-tracking branch 'origin/cone-detect-map-test' into cone-…
6d38f7f 
…detect-map-test

# Conflicts:
#	src/moa/cone-detection/cone_detection/detection_final.py
@dyu056
Corrected the message for fitting cone mapping message
e63cbd5
@dyu056
Established detect-map communication. Now need tuning
9e69c09
@dyu056
To do list from 11-24:
ea90fbb 
- Need to design way to delete unreal node
- Need to make foxglove visualizer
@dyu056
To do list from 11-24:
d4a0dce 
- Need to design way to delete unreal node
- Need to make foxglove visualizer
@dyu056
11-24
09014ad
@dyu056
Fix docker
bfb900c
@dyu056
add virtual sensor
9a4682a
cone map service->subscriber
e59b68b
@dyu056
Merge pull request #68 from UOA-FSAE/cone-detect-map-test
c8adeaa 
Cone detect map test
pytests added for path planning
98d26c6
custom all trajectory states message & 3 separate path planning nodes
9fb97f5
@Tanish29
Merge branch 'nightly' into 58-feat-path-planning
08683ab
@Tanish29
Merge pull request #64 from UOA-FSAE/58-feat-path-planning
5a71bb7 
58 feat path planning
@Tanish29
Merge branch 'nightly' into 5-feat-can-interface-node
1e79e5e
@Tanish29 Tanish29 closed this Jul 18, 2024
@Tanish29 Tanish29 deleted the 5-feat-can-interface-node branch July 18, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qube1t qube1t qube1t left review comments

@Zane-Larking Zane-Larking Zane-Larking left review comments

Assignees

@Jack17432 Jack17432

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[✨FEAT✨]: CAN interface node
8 participants
@Jack17432 @Zane-Larking @qube1t @Tanish29 @YachtChen @waldosingleton @csprono @dyu056