Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An SSH connection is created for each input file to be copied to the VM #26

Open
NicholasMy opened this issue Feb 27, 2023 · 0 comments
Assignees

Comments

@NicholasMy
Copy link
Member

In the current design, a new SSH connection is established for each file being copied into the VM.

Tango/vmms/distDocker.py

Lines 205 to 218 in 34c6ca7

for file in inputFiles:
ret = timeout(["scp"] + DistDocker._SSH_FLAGS + vm.ssh_flags +
DistDocker._SSH_AUTH_FLAGS + [file.localFile] +
["%s@%s:%s/%s" % \
(self.hostUser, vm.domain_name, volumePath, file.destFile)],
config.Config.COPYIN_TIMEOUT)
if ret == 0:
self.log.debug('Copied in file %s to %s' %
(file.localFile, volumePath + file.destFile))
else:
self.log.error(
"Error: failed to copy file %s to VM %s with status %s" %
(file.localFile, vm.domain_name, str(ret)))
return ret

Grading could be greatly sped up if multiple files were copied with one connection rather than wasting time closing and reopening the connection.

@NicholasMy NicholasMy self-assigned this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant