Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL with more than one 'symphony' string make "File browser" not work #18

Open
r00dY opened this issue Aug 29, 2012 · 1 comment
Open

Comments

@r00dY
Copy link

r00dY commented Aug 29, 2012

Hello kanduvisla,

In ckeditor/assets/filebrowser.js, line 8:

Symphony.WEBSITE = window.location.toString().match(/^(.+?)\/symphony/)[1];

you use "lazy plus", I mean ".+?" regexp.

I've put up new environment recently, and URL to my new project's symphony administration panel looked this way:

http://127.0.0.1/symphony/PROJECT/symphony/

Unfortunately, your way of extracting Symphony.WEBSITE gives only http://127.0.0.1, because regexp stops after first symphony string. If you use "greedy plus" (only .+, without ?), it would properly give http://127.0.0.1/symphony/PROJECT and this makes file browser work properly.

It took me quite a bit to look this bug up! I hope that my little contribution will help somebody in the future ;)

cheers

@kanduvisla
Copy link

Could you make a pull request for this?

kanduvisla added a commit that referenced this issue Aug 31, 2012
bugfix to issue #18 / multiple "symphony" strings in URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants