Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Ext] HTML Builder #1202

Closed
wants to merge 7 commits into from
Closed

[New Ext] HTML Builder #1202

wants to merge 7 commits into from
+288 −1

Conversation

showierdata9978
Copy link

@showierdata9978 showierdata9978 commented Dec 15, 2023 •
edited
Loading

I made this for a friend buts its useful anyways.

@showierdata9978
Copy link
Author

showierdata9978 commented Dec 15, 2023 •
edited
Loading

breh, how am i supposed to test if im not using localhost

-- force push deleted example --

@CST1229
Copy link
Collaborator

CST1229 commented Dec 15, 2023 •
edited
Loading

breh, how am i supposed to test if im not using localhost

use localhost (npm ci then npm run dev in the repo directory) wait nvm this is for the sample probably

@showierdata9978
Copy link
Author

breh, how am i supposed to test if im not using localhost

use localhost (npm ci then npm run dev in the repo directory)

i am lol

@showierdata9978
Copy link
Author

^ got rid of the example because im not dealing with that rn

LilyMakesThings
LilyMakesThings suggested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@LilyMakesThings LilyMakesThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the contributing guidelines in full.

extensions/ShowierData9978/html.js Show resolved Hide resolved
extensions/ShowierData9978/html.js Outdated Show resolved Hide resolved
extensions/ShowierData9978/html.js Outdated Show resolved Hide resolved
extensions/ShowierData9978/html.js Outdated Show resolved Hide resolved
LilyMakesThings
LilyMakesThings approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@LilyMakesThings LilyMakesThings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of this extension, a really fun concept

@showierdata9978
Copy link
Author

dk if i should add a section with alot of element specific blocks

@showierdata9978
Copy link
Author

showierdata9978 commented Dec 16, 2023 •
edited
Loading

image

   <!DOCTYPE html>
   <html lang="en">
    <head >
     <title >TW HTML</title>
     <meta name="viewport" content="width=device-width,initial-scale=1" />
     <style >
      html, body {
                height: 100vh;
                 width: 100vw;
                margin: 0px;
                padding: 0px;
                background-color: grey;
      }
      
      p {
                color: white;
      }
     </style>
    </head>
    <body >
     <p >
      Some Text
     </p>
    </body>
   </html>

@showierdata9978
Copy link
Author

showierdata9978 commented Dec 18, 2023 •
edited
Loading

image
if someone has a better tw svg, that would be nice because i had to trace it.

@GarboMuffin
Copy link
Member

this is certainly creative

  • you should probably be escaping things like tag names
  • what should happen if multiple scripts both start running these blocks? should there just be one big stack or each of them getting their own?

@showierdata9978
Copy link
Author

showierdata9978 commented Dec 21, 2023 •
edited
Loading

this is certainly creative

* you should probably be escaping things like tag names

* what should happen if multiple scripts both start running these blocks? should there just be one big stack or each of them getting their own?
  • 1 yeah i should, slight issue with that though, i cant escape the insert raw as that would just be false advertising (and break the ext)
  • 2 there is one stack, however utils was undefined from my testing (might have been user error)

@showierdata9978
Copy link
Author

this is certainly creative

* you should probably be escaping things like tag names

* what should happen if multiple scripts both start running these blocks? should there just be one big stack or each of them getting their own?

separated them, and escaped them

@showierdata9978
Copy link
Author

.

@BlueDome77
Copy link
Contributor

image if someone has a better tw svg, that would be nice because i had to trace it.

Maybe this would help:
Turbowarp Logo

@showierdata9978
Copy link
Author

showierdata9978 commented Jan 8, 2024 via email

@samuellouf
Copy link
Contributor

Here's a svg :
turbowarp

@showierdata9978
Copy link
Author

HTWL

@showierdata9978
Add icon, and add it to ext list
1c76024 
 (Figma source file for icon provided)
@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@yuri-kiss
Copy link
Member

Please fix the merge conflicts so this can get a proper review without any issues.

@showierdata9978
Copy link
Author

I don't use github anymore by the way. Feel free to take over this :P

@yuri-kiss
Copy link
Member

I don't use github anymore by the way. Feel free to take over this :P

If its not going to be worked on im gonna close this.

@yuri-kiss yuri-kiss closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CST1229 CST1229 CST1229 left review comments

@LilyMakesThings LilyMakesThings LilyMakesThings approved these changes

Assignees
No one assigned
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@showierdata9978 @CST1229 @GarboMuffin @BlueDome77 @samuellouf @yuri-kiss @LilyMakesThings