-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature request) Prevent options note title changes #556
Comments
Yes, I've always found it weird. The problem is a bit more nuanced, in the sense that we probably need to block a whole lot of changes to options, including moving them around, changing their icon, hiding the ribbon and so on. Honestly, I would have fallen back to the original implementation where the settings were a modal and not special note types that reside in the user's database. @perfectra1n , I think you have a similar position to mine. |
Yeah, I always thought it was weird to have a "settings" page that wasn't a modal. I remember when he first implemented the change, I was confused for a solid few minutes 🤣 |
I'm 100% for the modal of all things settings related - we can definitely make it look good too :) |
I've had a similar feedback about not understanding exactly how to exit from settings. Because it's not immediately apparent to a new user that the settings are opening in their own tab, rather than replacing the existing one. Similarly, one of the key reasons I've mode from KeeWeb to a more traditional password manager were the settings screen that would replace the password list, and making my brain confused since it seemed exactly the same as the normal screen. I might give it a go at turning it back into a modal. @meichthys , what's your take on this? |
I thought that having the options resemble the functionality of a note was interesting, but also a bit unexpected as a user. |
I also think making Options function similarly to Notes is interesting, as it opens in a tab, making it convenient to switch between Notes and Options. We could also implement a widget to prevent editing of titles and similar content, add an ESC key shortcut to exit, and other features to make it more consistent with modal operation habits. |
I certainly won't be in charge of making it look good 🤣 |
@SiriusXT , a hybrid might work, a single note that contains a settings widget which also has built-in navigation. @perfectra1n , @meichthys , @SiriusXT , I believe we should look into how other applications handle this. I think Obsidian uses a modal. The only one I am aware of that uses this tabbed design is Visual Studio Code. There the settings open in a new tab (same us), with tree being unaffected. Clicking on a note/file in tree causes it to be opened in a new tab, with the settings remaining open. I think this might be a good common ground since we reduce some of the complexity of the user, while still maintaining the benefits of having settings in a dedicated tab. |
This sounds like a reasonable middle ground for me. Generally i prefer modals to be ephemeral (i.e. easy to close out by clicking outside of the modal). This is great for quick notices, for shortcuts, recent notes, and others, but for settings that may require the user to press a 'save' button, I think those would better be addressed with a more 'fixed' page. |
Describe feature
Currently the title of the options notes can be changed:
For consistency sake, we should probably not allow the options note titles to be changed.
Additional Information
No response
The text was updated successfully, but these errors were encountered: