Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug report) Search not working correctly #162

Closed
alexpietsch opened this issue May 24, 2024 · 0 comments · Fixed by #215
Closed

(Bug report) Search not working correctly #162

alexpietsch opened this issue May 24, 2024 · 0 comments · Fixed by #215
Labels
bug Something isn't working
Milestone

Comments

@alexpietsch
Copy link
Member

alexpietsch commented May 24, 2024

Trilium Version

What operating system are you using?

Ubuntu

What is your setup?

Local (no sync)

Operating System Version

Linux ubuntu 6.5.0-35-generic #35~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue May 7 09:00:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

Description

When running the "search" jasmin tests, the assertions fail.
Mostly, the number of search results is wrong, or values which should be truthy are undefined.

Steps to reproduce:

  • Check out unit tests feature branch (feat/ts-unit-and-integration-tests)
  • Run the tests via npm run test-jasmine

Expected result: 8 failures (as on current master)

Actual result: 20 failures

Note:
- To help debugging, set searchContext.debug = true;
- Running the tests is still wip, so some may fail for different reasons

Error logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants