Skip to content
This repository has been archived by the owner on Jun 26, 2021. It is now read-only.

Proposal: Change the interface for action groups to include store name #22

Open
JRJurman opened this issue Oct 1, 2018 · 0 comments
Open

Comments

@JRJurman
Copy link
Member

JRJurman commented Oct 1, 2018

Summary

The current interface for passing action groups is a key: action group, where the key is the store name. It might be more clear instead to have a dedicated key for action groups that is intelligently used

Current

engine.addActions({
  storeName: {
    init: () => 5
  }
})

Proposal

engine.addActions([
  {
    store: 'storeName',
    init: () => 5
  }
])

While this may seem trivial here, it means that action files (which are usually separate) can also dictate the storeName, rather than having those exclusively defined when the engine adds them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant