[Bug]: Four Osc Synth Clicks while in Mono Mode

[LiamGallagherBC]

Detailed steps on how to reproduce the bug

• Open up wave form.
• Add Four Osc to a track.
• Switch Four Osc to Mono mode in the Global settings area.
• Play any rhythmically staggered vertical structure, chords or triads or whatever.
• Hear clicking when the synth transitions from one note to the next.

2024-05-28.10-47-27.mp4

What is the expected behaviour?

The synth should transition smoothly between notes.

Unit test to reproduce the error?

NA

Operating systems

Windows

What versions of the operating systems?

10

Architectures

x86_64

Stacktrace

NA

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

Waveform.

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

• I agree to follow the Code of Conduct

[FigBug]

FourOscPlugin uses juce::MPESynthesiser internally which has terrible voice stealing algorithm. I'll try and find a way to work around it.

[FigBug]

Actually, I did implement a somewhat better voice stealing algorithm. Can you find this line

            isQuickStop ? std::min (0.01f, paramValue (synth.ampRelease))
                        : paramValue (synth.ampRelease)`

And try increasing 0.01f, does that reduce the click?

[LiamGallagherBC]

That certainly helps, but doesn't resolve it entirely. Do you have a suggestion for a good value to use?

[FigBug]

It's a bad design I think I just need to rework how the voice handling works.

[LiamGallagherBC]

Fair enough! If I can help you out at all please let me know.