Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Storyline for specific quests, NPCs or daily quests #15

Open
Ellypse opened this issue Mar 27, 2018 · 0 comments
Open

Disable Storyline for specific quests, NPCs or daily quests #15

Ellypse opened this issue Mar 27, 2018 · 0 comments

Comments

@Ellypse
Copy link
Member

Ellypse commented Mar 27, 2018

We want to have an option to disable Storyline in some situations like some specific quests, some specific NPCs or for all daily quests.

  • We would need a blacklist of quests and of NPCs
  • An option to disable for all daily quests
  • The tricky part here is that in order to disable the default UI we have to unregister a bunch of stuff that makes it harder for us to show it back after that. Manually showing the UI in our code might create some issues with other add-ons that skip dialogs.
  • We can disable Storyline before events are fire, that's easy and we are already doing it for the dungeons and DMF filters.
  • An easy one would be to blacklist NPCs, and disable Storyline when the cursor is over those NPCs before the user even clicks to interact with them. But for quests, we need to get the quest data first, which is a chicken and egg situation.
  • Another possible workaround if we really can't do this would be to have a keybinding to toggle Storyline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant