Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: refactor codes and add logger #121

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[FEATURE]: refactor codes and add logger #121

merged 2 commits into from
Aug 29, 2023

Conversation

Behzad-rabiei
Copy link
Member

No description provided.

This was linked to issues Aug 28, 2023
Integrate Pino Logging Framework for Enhanced Application Monitoring #120
Closed
Improve code readability #73
Open
cyri113
cyri113 requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@cyri113 cyri113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Default logger: INFO?
  • Why are we not running tests in CI?
  • Do none of the tests need changes?

src/config/index.ts Show resolved Hide resolved
@cyri113 cyri113 mentioned this pull request Aug 28, 2023
Closed
@Behzad-rabiei
Copy link
Member Author

Behzad-rabiei commented Aug 28, 2023 •
edited
Loading

  • Default logger: INFO?
  • Why are we not running tests in CI?
  • Do none of the tests need changes?

@cyri113
For production we want to have logs like fatal, error, info, ... not trace or debug
So for the dev, I recommend setting LOG_LEVEL to trace (to include all logs) but for prod info

no changes for tests are needed and I do not know the status of the CI

@cyri113 cyri113 merged commit 0eead5f into development Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyri113 cyri113 cyri113 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve code readability Integrate Pino Logging Framework for Enhanced Application Monitoring
2 participants
@Behzad-rabiei @cyri113