-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix finding libmagic and lz4 #5307
Comments
Even passing
|
Finally, this also fails:
I.e.:
How to unbreak this? |
@teo-tsirpanis can you take a look please? |
@barracuda156 I am not sure what is the error you are getting. Does it reproduce locally or on a CI workflow? If it is the former, maybe a clean reconfigure after switching the branch will help. If it is in the context of updating Macports, I have opened macports/macports-ports#25731 to update to 2.26.0, and it passes CI on my fork. |
@teo-tsirpanis It is perfectly possible that libs are found and used, but configure messages are misleading. But they should be fixed then. Consider I am a user who is not aware of any internals and not reading this topic. What do I gather from this output?
This is confusing at best. Logically, the last message matters. No further info of configure status is displayed. Naturally, one concludes that it does not work correctly (even if it is not actually the case from perspective of CMake). |
I can confirm that despite configure messages, build indeed succeeds and links to needed libs:
IMO, configure output should still be fixed though. |
Let me better explain what is going on with the configure output.
LZ4 is a similar case of a dependency being acquired through multiple means: with the CMake package (which is not yet widely used among software distributions) or manually. The not found log message coming right before the found message says a similar story with libmagic. As for the duplicate not found log messages, this happens because we find libmagic and lz4 in two places. The second time, we try to find |
It should be trivial to find
libmagic
, since it has.pc
file, but it fails.I also do not understand what configure is doing with
lz4
, when it find it above and then again claims it is not found below.lz4
also has.pc
file:The text was updated successfully, but these errors were encountered: