From 09881ed0fdac30d5d9d4b92e386011b372a3faef Mon Sep 17 00:00:00 2001 From: George Powley Date: Tue, 24 Sep 2024 11:24:38 -0400 Subject: [PATCH 1/3] Improve missing object detection in upload_wheel --- src/tiledb/cloud/utilities/wheel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tiledb/cloud/utilities/wheel.py b/src/tiledb/cloud/utilities/wheel.py index c42e3913..5a892a05 100644 --- a/src/tiledb/cloud/utilities/wheel.py +++ b/src/tiledb/cloud/utilities/wheel.py @@ -71,7 +71,7 @@ def upload_wheel( ) # Create the array if it doesn't exist - if object_type is None: + if object_type is None or object_type == "None": tiledb.Array.create(dest_uri, tiledb.ArraySchema.from_file(wheel_path)) logger.info(f"Created filestore at '{dest_uri}'") elif object_type == "group": From f6ee1bc3fbdf64077cbec25a5d67ae28d1eaf591 Mon Sep 17 00:00:00 2001 From: George Powley Date: Tue, 24 Sep 2024 11:57:09 -0400 Subject: [PATCH 2/3] Update src/tiledb/cloud/utilities/wheel.py Co-authored-by: Isaiah Norton --- src/tiledb/cloud/utilities/wheel.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tiledb/cloud/utilities/wheel.py b/src/tiledb/cloud/utilities/wheel.py index 5a892a05..82cffc3a 100644 --- a/src/tiledb/cloud/utilities/wheel.py +++ b/src/tiledb/cloud/utilities/wheel.py @@ -71,6 +71,7 @@ def upload_wheel( ) # Create the array if it doesn't exist +# `object_type == "None"` is work-around for regression, see https://app.shortcut.com/tiledb-inc/story/55930 for fix if object_type is None or object_type == "None": tiledb.Array.create(dest_uri, tiledb.ArraySchema.from_file(wheel_path)) logger.info(f"Created filestore at '{dest_uri}'") From ee1f556a3a356d48cc4c26e6ae4d403975287c77 Mon Sep 17 00:00:00 2001 From: George Powley Date: Tue, 24 Sep 2024 11:59:38 -0400 Subject: [PATCH 3/3] format --- src/tiledb/cloud/utilities/wheel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tiledb/cloud/utilities/wheel.py b/src/tiledb/cloud/utilities/wheel.py index 82cffc3a..3f66e728 100644 --- a/src/tiledb/cloud/utilities/wheel.py +++ b/src/tiledb/cloud/utilities/wheel.py @@ -71,7 +71,8 @@ def upload_wheel( ) # Create the array if it doesn't exist -# `object_type == "None"` is work-around for regression, see https://app.shortcut.com/tiledb-inc/story/55930 for fix + # `object_type == "None"` is work-around for regression, + # see https://app.shortcut.com/tiledb-inc/story/55930 for fix if object_type is None or object_type == "None": tiledb.Array.create(dest_uri, tiledb.ArraySchema.from_file(wheel_path)) logger.info(f"Created filestore at '{dest_uri}'")