Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unnecessary refresh in Genesis widget #8895

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes unnecessary refresh in Genesis widget #8895

wants to merge 2 commits into from

Conversation

saqimtiaz
Copy link
Member

Fixes #8871

@github-actions GitHub Actions
Copy link

Confirmed: saqimtiaz has already signed the Contributor License Agreement (see contributing.md)

@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 00cf512
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/678a3e21ab3c9d000884767b
😎 Deploy Preview https://deploy-preview-8895--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmario
Copy link
Member

pmario commented Jan 17, 2025

I did test with the following tiddlers and it seems to work for standard, $ and $$ parameters

title: x
text: a

title: a
some text

title: b
text: bbb

title: test

<$genesis $type="$transclude" $$tiddler={{x}} $a={{a}} b={{b}}>
<<now [UTC]YYYY0MM0DD0hh0mm0ssXXX>>
</$genesis>

@Jermolene
Copy link
Member

Thanks @saqimtiaz that's an elegant fix

@saqimtiaz saqimtiaz marked this pull request as ready for review January 17, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Genesis widget always re-renders on first refresh cycle
3 participants
@saqimtiaz @pmario @Jermolene