Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Using external files do not work anymore #1168

Closed
ColinFay opened this issue Aug 27, 2024 · 2 comments
Closed

[BUG] Using external files do not work anymore #1168

ColinFay opened this issue Aug 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ColinFay
Copy link
Member

ColinFay commented Aug 27, 2024

Bug description

There is a bug in all the functions that try to download from the web, on the version that has been sent to CRAN (0.5.0).

Root cause

utils::download.file is bootstraped here https://github.com/ThinkR-open/golem/blob/master/R/boostrap_base.R#L7

But i have forgotten to remove it from here : https://github.com/ThinkR-open/golem/blob/master/R/use_files.R#L2

Making utils_download_files call itself recursively and failing.

Solution

Doing a hotfix right now and resubmitting to CRAN.

@ColinFay ColinFay added the bug Something isn't working label Aug 27, 2024
@ColinFay ColinFay self-assigned this Aug 27, 2024
@ColinFay
Copy link
Member Author

ColinFay commented Aug 27, 2024

Closed via #1169

@ColinFay
Copy link
Member Author

Republished to CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant