-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: use codecov badge depending on the current git branch #1087
Conversation
- to clearly show what the testing coverage is on each branch via the badge - `README.Rmd` is altered to programatically retrieve the current git branch which automatically uses the correct coverage results from https://about.codecov.io/ Refs: ThinkR-open#1086
hi, dont thinks It will works because we never push directly to master branch. |
hi, @VincentGuyader hmm tricky. I think it should work because the CI rebuilds e.g. on the current If this is the case, then the EDIT:
Do you mean the CI is not triggered when you merge from |
Actually, I was only talking about the GitHub homepage... I hadn't thought that you were referring to pkgdown, etc... so it's not that straightforward, let's try to find a way to have both? It would indeed be cool to have different coverage based on the branch. |
- when CI rebuilds README.Rmd it should also use the badge of the git-branch so the codecov gets an update
@VincentGuyader so breaking up the problem
|
Let's try and merge it to an intermediate branch |
I can confirm that it works, merging to dev soon |
Now in dev #1133 |
Fix #1086
This PR implements a changing codecov status badge dependening on the current git-branch of the
{golem}
projects.README.Rmd
is altered to programmatically retrieve the current git branch and alter links to point to the correct coverage results from https://about.codecov.io/ for the svg-images and webpages.