Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Bar can be used in exit menu #2548

Open
xezon opened this issue Nov 12, 2024 · 5 comments · May be fixed by #2574
Open

Control Bar can be used in exit menu #2548

xezon opened this issue Nov 12, 2024 · 5 comments · May be fixed by #2574
Labels
Design Is a matter of game design ExecutableMaybe Is perhaps game code related GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker

Comments

@xezon
Copy link
Collaborator

xezon commented Nov 12, 2024

Control Bar can be used in exit menu.

2024-11-13_04-01-45.mp4
@xezon xezon added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker GUI For graphical user interface labels Nov 12, 2024
@xezon
Copy link
Collaborator Author

xezon commented Jan 12, 2025

After testing

I think it is fine to leave the controls as per the original, because it allows to toggle the exit menu with the menu button on the center Control Bar, and also allows to quickly close the exit menu by opening the Generals Powers screen or Diplomacy screen.

I think the main issue here is that the user can interact with the Control Bar and the world in part. So for example it is not possible to select units, but it is possible to deselect them while the exit menu is opened. It is also possible to buy upgrades, sell buildings, ... There are differences between Skirmish and Network, because in Skirmish the game is paused, but in Network it keeps running and more interactions are possible. Tooltips also show inconsistently: They are hidden when hovering over buttons, but are shown when hovering over money or power bar.

@xezon xezon added the Executable Is game code related label Jan 12, 2025
@xezon
Copy link
Collaborator Author

xezon commented Jan 12, 2025

I think a potential fix here could be to close the exit menu when clicking any button on the Control Bar. Right now, the exit menu closes when clicking specific buttons only. Unclear if this behaviour is INI controlled or part of game code.

@xezon xezon added ExecutableMaybe Is perhaps game code related and removed Executable Is game code related labels Jan 12, 2025
@DevGeniusCode
Copy link
Contributor

but it is possible to deselect them while the exit menu is opened

Note that in Skirmish you can cancel the items you bought but they are not really canceled, if you refresh the view (select something else and then select the building with the items you bought again), nothing is canceled, but in Network they are canceled, I hope I was clear.

In general, why should interaction with the game be allowed when the menu is shown? When the options menu or exit dialog is shown, interaction is completely blocked. I can't think of a situation where anyone would want to interact specifically when the menu is shown.

to quickly close the exit menu by opening the Generals Powers screen or Diplomacy screen.

Or just press Return to game, I use the Esc button

@xezon
Copy link
Collaborator Author

xezon commented Jan 13, 2025

We would essentially take away control if we blocked the input, which would be a detriment over the original. The original controls give the player more freedom to interact with the GUI.

@DevGeniusCode
Copy link
Contributor

more freedom to interact with the GUI.

It's not a bug, it's a feature. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design ExecutableMaybe Is perhaps game code related GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
2 participants