Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwind HtmlFormElement and improve the FormData API #115

Open
TheSpyder opened this issue Nov 4, 2022 · 0 comments
Open

Unwind HtmlFormElement and improve the FormData API #115

TheSpyder opened this issue Nov 4, 2022 · 0 comments

Comments

@TheSpyder
Copy link
Owner

There are two main problems with Webapi__Dom__HtmlFormElement:

  • It uses the Impl pattern but is never included by other files
  • It defines a data function to create a FormData object, which is both a weird name for the constructor and a weird place to put it

The first is an easy fix; just move all the bindings to the end of the file and delete the Impl module.

For the second, just delete data and re-do #108 (which was reverted after I discovered this).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheSpyder