What should be added next? #3
Replies: 2 comments 13 replies
-
|
Just wanted to say this looks great. You've done a nicer job of my own component, love that you just set everything once and then choose which meta you want generated (eg. Twitter, OG etc). |
Beta Was this translation helpful? Give feedback.
-
|
Haha, you're the first person to comment on it! :-) Is there a way to set defaults (eg. set a site wide image for pages that don't have one) and then override it on particular pages? |
Beta Was this translation helpful? Give feedback.
-
You can set site wide defaults by just setting <Seo
imageURL="/seo.png"
logo="/favicon.png"
author="Dahoom AlShaya"
name="Dahoom AlShaya"
/> note that you can just use It's difficult to set overrides since at the point you reach other pages, this information will already be appended to the header and applying it again will cause a duplicate meta tag. The way I would do it is that i would not use "imageURL" prop in <script>
export let title = "", imageURL = "/default.png" //...
</script>Then you can do this by something like: <script>
import Seo from '$lib/newSEOfile/Seo.svelte';
</script>
<Seo
title="contact me"
imageURL="/contact.png"
/>This way you can avoid any conflicts or duplicates and don't have to explicitly set the imageURL for each page if you don't have to. This is just my approach though! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, that makes sense. It would be quite helpful if there was a way to provide a fallback image, title and author for pages where it doesn't need additional SEO (or I forget to add the component!). Would it make sense to do this via configuration in the module itself? |
Beta Was this translation helpful? Give feedback.
-
I tried to add a javascript check that scans |
Beta Was this translation helpful? Give feedback.
-
|
Will have a think about it and if I come up with anything that works well, submit a PR. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @TheDahoom . |
Beta Was this translation helpful? Give feedback.
-
|
Svelte 5 compatible version could just be branched out separately I think. For now I would recommend relying on svelte-5's backward compatibility until the adoption rate of svelte 5 is higher. My reasoning: Just looking at this week's npm installs you can see svelte 4's latest version is pretty high |
Beta Was this translation helpful? Give feedback.
-
|
Alright, then lets keep them on two different branches (as I'm also aleady doing on my fork). |
Beta Was this translation helpful? Give feedback.
-
Same here, I understand the reasoning behind the changes but the new syntax just doesn't click with me |
Beta Was this translation helpful? Give feedback.
-
|
If you're ready you can submit PRs for main and next branch (next containing svelte 5 syntax) and I can review the code one more time then we can release v0.5.0 and v0.5.0-next :) |
Beta Was this translation helpful? Give feedback.
-
|
I'll make a PR asap. |
Beta Was this translation helpful? Give feedback.
-
I finished all the features I would personally want in an SEO component, but what would you like to be added? Request any features/fixes/improvements and depending on the feasibility I'll add it to the todo list so it can be the best version of itself by 1.0!
Beta Was this translation helpful? Give feedback.
All reactions