New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easy+: Add a reasonable CI (rustfmt check, verify compilation) #11

Open

luciusmagn opened this issue Mar 22, 2022 · 1 comment

Labels

good first issue

Member

luciusmagn commented Mar 22, 2022

It should be easy to add these, the harder part is making it fast (perhaps by adding sccache or looking into github actions caching options)

use cargo fmt --check to verify formatting -> run from repo root with the flag --all
for now, I think only doing a cargo check --all --all-targets is enough to verify the code compiles

In other words, if you commit unformatted code, I will bombard your mom

The text was updated successfully, but these errors were encountered:

lajp added the good first issue label

Member

lajp commented Mar 24, 2022 •

edited

Loading

if you commit unformatted code, I will bombard your mom

Luckily I'm unable to commit unformatted code. Phew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment