Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded values #11

Open
ahnl opened this issue May 27, 2022 · 2 comments
Open

Hard-coded values #11

ahnl opened this issue May 27, 2022 · 2 comments

Comments

@ahnl
Copy link
Member

ahnl commented May 27, 2022

These constants probably should be moved to .env configuration. Low impact and non-critical issue.

const rolesWhitelistedForDataExport = ["743950610080071801"]
const rolesWhitelistedForConsensualDataExport = ["839072621060423771", "755327895106486324"]
const discordCallback = `${address}/v1/discord/connections/authorized`
const mainServer = "697710787636101202"

@Esinko
Copy link
Member

Esinko commented May 27, 2022

Please bare in mind that the main branch has changed and that file does not exist anymore. Current location is src/routes/discord.js

@ahnl
Copy link
Member Author

ahnl commented May 27, 2022

Please bare in mind that the main branch has changed and that file does not exist anymore. Current location is src/routes/discord.js

Thank you for noting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants