Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen. #315

Open
ChitvanRamani22 opened this issue Jun 16, 2021 · 16 comments
Open

Splash screen. #315

ChitvanRamani22 opened this issue Jun 16, 2021 · 16 comments
Labels
Hactoberfest 🤩 Up for Grab This issue will is not assigned ! Grab It !

Comments

@ChitvanRamani22
Copy link
Collaborator

ChitvanRamani22 commented Jun 16, 2021

We could add an interactive splash screen just before opening the signin page ,it will look good.
Use can use react lazy, suspense.

@ChitvanRamani22 ChitvanRamani22 added LGMSOC21 This issue will be considered for LGM-SOC 21 up-for-grab labels Jun 16, 2021
@AmeyaJain-25
Copy link
Collaborator

@ChitvanRamani22 ,
React lazy is used.
Just a small loader is added. A circular one.
So, one can add another proper loader splash with keeping mind of the theme.
This can be applied combinly to all pages.

@ChitvanRamani22
Copy link
Collaborator Author

ChitvanRamani22 commented Jun 16, 2021

@AmeyaJain-25 yeah react lazy is used but timsout and all needs to be done.
I think 3000 ms is enough
WDYT?

@AmeyaJain-25
Copy link
Collaborator

@AmeyaJain-25 yeah react lazy is used but timsout and all needs to be done.
I think 3000 ms is enough
WDYT?

Yep..
That may be perfect

@ambalika24
Copy link
Contributor

@AmeyaJain-25 , @ChitvanRamani22 I want to work on this issue. Just wanted to ask - are we expecting a full splash screen page or just a change in circular progress loader?

@ChitvanRamani22
Copy link
Collaborator Author

@ambalika24 it should be a full screen splash which should appear for 3000ms before the signin page appears.

@ChitvanRamani22
Copy link
Collaborator Author

@ChitvanRamani22
Copy link
Collaborator Author

@ambalika24 do you want to work on this?

@ambalika24
Copy link
Contributor

@ambalika24 do you want to work on this?

Yes ma'am. Please assign this issue to me.

@AmeyaJain-25
Copy link
Collaborator

Any update @ambalika24 ?

@ambalika24
Copy link
Contributor

Any update @ambalika24 ?
Yes Sir, I am working on it's design

@ambalika24
Copy link
Contributor

Any update @ambalika24 ?

@AmeyaJain-25 Sir, I have finalized the design. May i show you the sample?

@ChitvanRamani22
Copy link
Collaborator Author

@ambalika24 yes you can show the template.

@ChitvanRamani22
Copy link
Collaborator Author

@ambalika24 can you once record it in such a way that after the preloader the signin page is also visible?
Thanks

@ambalika24
Copy link
Contributor

@ambalika24 can you once record it in such a way that after the preloader the signin page is also visible?
Thanks

@ChitvanRamani22 ma'am, did it work?

@AmeyaJain-25
Copy link
Collaborator

@ChitvanRamani22 , Please have a look to this. If it's all good, then let @ambalika24 dp the further steps to make the PR

@ChitvanRamani22 ChitvanRamani22 added 🤩 Up for Grab This issue will is not assigned ! Grab It ! and removed assigned labels Aug 11, 2021
@AmeyaJain-25 AmeyaJain-25 added Hactoberfest and removed LGMSOC21 This issue will be considered for LGM-SOC 21 labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hactoberfest 🤩 Up for Grab This issue will is not assigned ! Grab It !
Projects
None yet
Development

No branches or pull requests

3 participants