Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update haproxy image #32

Open
JanoschDeurer opened this issue Oct 21, 2020 · 8 comments
Open

Automatically update haproxy image #32

JanoschDeurer opened this issue Oct 21, 2020 · 8 comments

Comments

@JanoschDeurer
Copy link

It would be great to use something like renovate or dependabot to automatically update the haproxy image so security fixes in haproxy are applied instantly.

@joao-p-marques
Copy link
Contributor

It is a good idea! Maybe dependabot would be a good solution. @yajo?

@JanoschDeurer
Copy link
Author

I'm using renovate myself so if you decide for that I could also provide some input.

@joao-p-marques
Copy link
Contributor

If you are willing to make a PR with a start, that would be good.

@JanoschDeurer
Copy link
Author

I forked and activated renovate on my repo. It seems that renovate has a problem with how the image is specified in the Dockerfile. I have an idea of how to solve it, but I'll have to further look into it. Is REPO build arg necessary for you? Otherwise I could just rewrite the FROM to:

FROM haproxy:1.9-alpine

Otherwise I'll have to look up how to override the regex renovate is using to find the location of the image string.

@joao-p-marques
Copy link
Contributor

Ok, thank you.

As for the REPO arg, I would have to ask @yajo

@yajo
Copy link
Contributor

yajo commented Nov 27, 2020

We can't have such thing without good coverage. #34 is still more important IMHO.

@JanoschDeurer
Copy link
Author

How about if we have nightly and stable versions? With this the user of the image could choose whether to always use the version with the latest haproxy or not.

I ran into this again because there is currently a permission problem with this repo and the latest haproxy image. I think it would be great if I could fix the issue that I am having in here so everyone can profit.

@yajo
Copy link
Contributor

yajo commented Jun 8, 2021

We now have the automation required for this to be acceptable. However, it's not our current priority. Community contributions welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants