Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider breaking test suite code into a standalone npm module #315

Open
slifty opened this issue Feb 4, 2020 · 1 comment
Open

Consider breaking test suite code into a standalone npm module #315

slifty opened this issue Feb 4, 2020 · 1 comment
Labels
conversation Let's talk about this

Comments

@slifty
Copy link
Contributor

slifty commented Feb 4, 2020

When testing the CNN scraper utilities we wrote a little script that would generate a slew of tests from a URL and package the inputs / outputs of various steps which could then be invoked as part of a test suite. I'm realizing there might actually be some value in using a similar methodology to test the actual CNN scraper, which means I'm revisiting those scripts and starting to make them more generic.

The functionality here is getting to the point that it might actually be something that could exist as its own developer tool / npm module. The value of this approach is:

  1. It would be usable across other projects.
  2. It would be explicitly isolated from our code / the functionality would be documented on its own without complicating our documentation.
  3. It could be managed and maintained outside of just this project.

Curious what others think.

@slifty slifty added the conversation Let's talk about this label Feb 4, 2020
@slifty slifty changed the title Consider breaking test suite generation into a library Consider breaking test suite code into a standalone npm module Feb 4, 2020
@reefdog
Copy link
Collaborator

reefdog commented Feb 19, 2020

I like this idea. The baby steps toward this would be:

  1. Make the code more generic w/in our own project (Modify test suite code to be more generic #316)
  2. Break it out into a private npm module (for testing/developing use as a module but without the time overhead of a publicly-offered module)
  3. Prep it for public use and make it a public module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conversation Let's talk about this
Projects
None yet
Development

No branches or pull requests

2 participants