Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let player capture Home and End keys #3706

Open
1 task done
opusforlife2 opened this issue Jul 13, 2024 · 5 comments
Open
1 task done

Don't let player capture Home and End keys #3706

opusforlife2 opened this issue Jul 13, 2024 · 5 comments
Labels
bug Something isn't working discussion More opinions needed

Comments

@opusforlife2
Copy link
Contributor

Official Instance

Describe the bug

Along with Pg Up and Pg Dn, the Home and End keys can be used to jump scroll pages. However, on Piped, the latter 2 keys are captured by the player, and instead of jumping to the page top and bottom, they jump to the video beginning and end.

To Reproduce

  1. Play any video.
  2. Use the Pg Up and Pg Dn keys. These work fine.
  3. Use the Home and End keys. These restart/end the video instead of scrolling the page.

Expected behavior

The player should not capture the Home and End keys.

Logs/Errors

No response

Browser, and OS with Version.

Firefox 128, W10.

Additional context

No response

@opusforlife2 opusforlife2 added the bug Something isn't working label Jul 13, 2024
@Bnyro
Copy link
Member

Bnyro commented Jul 14, 2024

Imo it's reasonable enough to capture home and end keys, that's been added with #3664 and should be the expected behavior.

@Bnyro Bnyro added the discussion More opinions needed label Jul 14, 2024
@opusforlife2
Copy link
Contributor Author

That PR has no description or sample video so I can't tell how it uses these keys.

Anyway, I think the main idea here is that when the focus is with the player, it's expected that certain keys will have overrides to act as shortcuts for various player functions.

However, when the player loses focus, the keys should go back to performing functions expected of them for the rest of the webpage.

@AndyRusso
Copy link
Contributor

I agree with OP. I have lost my position in videos when pressing home key while being deep into reading comments to go back up - it's not intuitive to capture home and end keys at all times in my opinion.

@ac615223s5
Copy link
Contributor

I added it because it is the behaviour on youtube but I don't mind either way. Also, it's related to #3136.

@opusforlife2
Copy link
Contributor Author

I vaguely remember back when I used Youtube that it had pretty wacky behaviour. This might have been one of those things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion More opinions needed
Projects
None yet
Development

No branches or pull requests

4 participants