Play a video in a popup when the network is off, then the app will be not responding

[Kobayashi-996]

Checklist

• I am able to reproduce the bug with the latest version.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.24.1 and 0.23.3

Steps to reproduce the bug

1. Open the app and go to the main page "Trending"
2. After the page finishes loading, turn off the network of the phone (for example, open flight mode)
3. Long Click one video
4. Click "Start playing in a popup", the video would keep loading and soon the app isn't responding

Expected behavior

For example hint network error.

Actual behavior

The app isn't responding.

Screenshots/Screen recordings

test.mp4

Logs

ANR in org.schabi.newpipe
PID: 26591
Reason: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{96e480e u0 org.schabi.newpipe/.player.PlayerService}

Affected Android/Custom ROM version

Android 9.0

Affected device model

Google Pixel 2

Additional information

If I click "X" instead of waiting when the video is loading without network, the app would immediately crash and then get this:

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: US
• Content Language: en-US
• App Language: en_US
• Service: none
• Version: 0.24.1
• OS: Linux Android 9 - 28

Crash log

android.app.RemoteServiceException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{1a62810 u0 org.schabi.newpipe/.player.PlayerService}
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1737)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6669)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

---

[Coderdude112]

Might be duplicate of #9030 or #9390

[opusforlife2]

Nope.

[AudricV]

They still have the same origin though. Could you look at #9358 (comment) and test the debug APK linked to see if the issue is fixed? Thanks in advance.

[Kobayashi-996]

I have tried the app in the link and found that the app not crash any more in the aforementioned situation. I think the issue is fixed. Thank you very much!