-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back button returns to older video rather than actually going back #8864
Comments
That seems to be a different back button bug. |
Some clarification is needed. What your video shows is the expected behaviour. What I think you're asking: if B is playing, then tapping Back should minimise the video to the mini player just like what happened for A? Is that correct? |
Yeah, that's what I expect. If I hit back, I expect it to return to where I was last, which was the search menu. |
I suppose if the video is playing, we could minimise it to the mini player and show the underlying screen. Tapping Back here accidentally causes a temporary "loss" of the playing video, after all. But I don't think it should be done for paused videos, or video pages with thumbnails (where the video hasn't been played yet). If that happens, there will be no way left to navigate through the backstack. |
I find this intended behavior weird. If I hit the back button, I expect it to go where I was last. So if I'm on home, search up a video, play it, then hit back, I expect it go back to the seach screen. Why is the expected behavior to jump all the way back to the video that was playing earlier? It's just annoying to have to hit back twice to get back to search. If I open a new video, I expect the older video to be closed, not inserted in the backstack where I don't expect it. Just my personal opinion and expectations though. Also, here's how the official YouTube app works for comparison: Screen_Recording_20220823-163621_YouTube.mp4 |
Are you saying that the backstack shouldn't exist?
The action made for that is to swipe down on the playing video. You'll get to the search screen. |
it's not a bug, this is how it's supposed to behave and in my opinion is better this way, however i would argue it would be better if there is a toggle in settings to choose the back button preferred behavior . don't you think |
I finally managed to understand, reading this issue, some of the extremely weird and apparently unpredictable behavior of the back button in NewPipe. I found out here and in other github issues that there seems to be a feature, the "backstack", that maybe some developers and some of the probably very few users who heard about it use. Well sorry, but it seems nonsense. The back button has a universally known precise function and unless you first prominently informed your users and let them choose otherwise, it needs to perform that function. I'm not sure you realize that you're currently doing this instead:
If I now tap the back button, the obvious point where to go back is X, the search screen. It is:
The current behavior seems to be meant to have a sort of "see later" feature. Alternative common, intuitive and actually useable ways to support that feature are:
I note that having an easily accessible queue and an enqueue command available even when there's no video playing, could be a somewhat decent substitute for this feature, although, maybe not 🤷 . Also to note that it's common to desire to "see later" not only single videos but also complete (YouTube) playlists. And anyway, what matters is to make the back button behave sensibly, even if it meant not having anymore anything akin to the "backstack" feature. * by the way, I read criticisms of it but to me the "scroll down" feature of the videos' pages has always seemed intuitve, I think it seemed obvious to try to scroll it down after seeing it "scroll up" |
Yes! That's exactly what I meant, thank you explaining it in a much better way than I did. |
To put it simply, it feels inconsistent because sometimes back minimizes the video (thus allowing listening to it while browsing the video list for other stuff) and other times back pauses the video and goes back to a previously opened video. |
Navigation is something that will probably need to be reworked as part of the rewrite. |
maybe it can be solved with a toggle to choose what behavior the back button should follow |
The problem is that the Back button is a fundamental part of the navigation flow. And there is basically no precedence for making it configurable, so any such modification would be surprising for users. The only customisation I'm personally aware of that many apps seem to use is whether to use a single tap or double tap to close the app. |
Agreed. Some apps allow you to choose whether or not you need to hit However, to the common, uninitiated user, the real surprise is the confusing The suggested option would rather offer them a one-time choice between
I, for one, could certainly take the time and wrap my mind around NewPipe's current navigation concept. Doing so would likely pay off quickly for me, personally, but I resist - not so much for the mental effort but because such effort shouldn't be required by an app that's meant to serve common people, in the first place. (By not understanding the concept, I'm still able to experience the confusion and, should that matter here, authentically discuss possible remedies.) |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as duplicate.
This comment was marked as duplicate.
i like back stack... but i also agree this sould be optional |
Checklist
Affected version
0.23.2
Steps to reproduce the bug
Expected behavior
The back button returns to the search screen and moves video B into the background.
Actual behavior
Video B stops playing completely and NewPipe returns directly to video A.
Screenshots/Screen recordings
Screen_Recording_20220823-000458_NewPipe.mp4
Logs
No response
Affected Android/Custom ROM version
Android 12
Affected device model
Samsung Galaxy S21
Additional information
No response
The text was updated successfully, but these errors were encountered: