-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search bar to the top of every screen #5902
Comments
why do you tap back if you can swipe the player down and get to the search instantly? |
Great idea! Yes, that would definitely work because from the main page we can search and also access our history in the app menu! Sorry for taking so long to respond. I rarely check my emails. Also, please consider the other feature requests for Advanced Search options. Those are SOOO nice in the YouTube Vanced app. I don't follow the official YouTube app, but I believe Vanced tries to copy it as best they can. Anything that makes those apps convenient and powerful should be attempted in NewPipe, IMO. If I were a coder I'd gladly help.
Sent from ProtonMail mobile
…-------- Original Message --------
On Mar 29, 2021, 11:10 PM, SameenAhnaf wrote:
How about if we use this button to directly get into main page? Search button is always on main page. It's still comparatively new and I am sure most users will prefer back button instead. If a user only wants to exit from the video, we can implement [#5675](#5675)
[112706343-c6390e80-8ecd-11eb-9481-cd72cefdfeb4](https://user-images.githubusercontent.com/79245641/112927991-b02e8680-9137-11eb-9b98-2d4501eba015.jpg)
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#5902 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AG56ID75DYQSZVCYJ43EFDDTGE6JRANCNFSM4ZXQEFFA).
|
It would also be nice if the playing video was sticky to the top of the app while scrolling through the comments, but I know - that's another feature request that I need to make if someone hasn't already :)
Sent from ProtonMail mobile
…-------- Original Message --------
On Mar 26, 2021, 9:36 PM, SameenAhnaf wrote:
***@***.***(https://github.com/mhmdanas) How about if we use this button to directly get into main page? Search button is always on main page. It's still comparatively new and I am sure most users will prefer back button instead. If a user completely wants to exit, we can implement [#5675](#5675)
[IMG_20210327_071840](https://user-images.githubusercontent.com/79245641/112706343-c6390e80-8ecd-11eb-9481-cd72cefdfeb4.jpg)
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#5902 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AG56IDYPVYSCXSCRJGJZUDLTFUZABANCNFSM4ZXQEFFA).
|
This comment has been minimized.
This comment has been minimized.
Primary controls and Search icon: On the top bar Search button could have 4 options with radio buttons. Mentioned words (if found) will be highlighted within the results of first two options.
|
I think any improvement like youve mentioned is welcome. to respond to the person who said why dont you just swipe down? that works from a video page, but not from a channel page or if ive clicked a video from a channel page.... and its even worse if ive navigated several channels deep. then i have to hit back a bunch of times to get to where i can search again. i should be able to search no matter what channel or video or newpipe page im on. |
What about turning all 'Back' buttons on the top left corner into 'x' icon (Clear current app activity and back to main page)? It should get your job done. Or, what about 'Home' icon (Keep current app activity and back to main page)? |
@SameenAhnaf I think either or even both of your ideas would be an improvement. Not ideal, but more convenient for sure which is fine by me since I don't possess the coding abilities to contribute.
Sent from ProtonMail mobile
…-------- Original Message --------
On Apr 22, 2021, 4:08 PM, SameenAhnaf wrote:
***@***.***(https://github.com/infinitewaveparticle) I would have loved to have that. But you see, search within a channel or playlist is already a feature in YouTube
and also requested for this app in [#5441](#5441).
If we add search on top of every screen, it may potentially lead users to think it just like a feature of YouTube. General search results (as you asked for) may seem irrelevant to them. We could have a discussion on this regard with other devs though.
At this moment, you may just close the app from recent apps and restart the app. If we implement my previous idea, it will do the exact same thing.
I recommend two more alternatives of Back button on top left corner
1.'x' icon (Clear current app activity and back to main page)? It should get your job done.
- 'Home' icon (Keep current app activity and back to main page)?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#5902 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AG56ID5KDC3MFJCTJ5JG5KLTKB645ANCNFSM4ZXQEFFA).
|
I really want this feature, that way I can circumvent the increasing pain it's becoming just to get back to the start screen. Even without the annoyance it would still be a useful feature. |
IMO it is always possible to swipe down and go searching and go through the results while a video is playing and go back to the video playing by tapping on it. Also one does not have to hit back many times to go to main screen. Could it be that this has been added already and could be closed? BTW I came here searching for feature requests regarding to be able to search and sort videos of a certain or all subscriptions. |
@timoon Read the comments above. It's already been suggested and pointed out there are cases where swiping down isn't possible. |
Closing in favor of #6194 |
Not a duplicate. Related, though. |
Checklist
Describe the feature you want
There should be a search bar permanently at the top of the app (for every screen in YouTube at least). I shouldn't have to hit back 100 times (if I've watched 100 videos) to be able to search. I should be able to search while a video is playing, but going back to where I can search stops the video.
Is your feature request related to a problem? Please describe it
Additional context
Can't add screenshots with this browser.
How will you/everyone benefit from this feature?
This feature will not only be super convenient, but it will also allow users who wish to search to not lose their "spot" in terms of video history. Users will still be able to hit back twice to get to 2 videos ago instead of having to hit back to the start page.
The text was updated successfully, but these errors were encountered: